Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21988 )

Change subject: IMPALA-13362: Implement WHEN NOT MATCHED BY SOURCE syntax for 
MERGE statement
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/21988/1/fe/src/main/java/org/apache/impala/planner/IcebergMergeNode.java
File fe/src/main/java/org/apache/impala/planner/IcebergMergeNode.java:

http://gerrit.cloudera.org:8080/#/c/21988/1/fe/src/main/java/org/apache/impala/planner/IcebergMergeNode.java@71
PS1, Line 71:           Expr.treesToThrift(mergeCase.getResultExprs()), 
mergeCase.caseType(), mergeCase.matchType());
line too long (103 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/21988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0e0607682a616ef6ad9eccf499dc0c5c9278c5f
Gerrit-Change-Number: 21988
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 29 Oct 2024 13:42:49 +0000
Gerrit-HasComments: Yes

Reply via email to