Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 63: (2 comments) http://gerrit.cloudera.org:8080/#/c/21142/60/be/src/catalog/workload-management-init.cc File be/src/catalog/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21142/60/be/src/catalog/workload-management-init.cc@517 PS60, Line 517: : // Set the default hostname if no hostname was specified on the startup flag. : if (FLAGS_hostname.empty()) { > Hmm, good question. I need to do more digging into this question. Setting Latest change I see in ps63 looks good. Thanks! http://gerrit.cloudera.org:8080/#/c/21142/63/be/src/workload_mgmt/workload-management.h File be/src/workload_mgmt/workload-management.h: http://gerrit.cloudera.org:8080/#/c/21142/63/be/src/workload_mgmt/workload-management.h@46 PS63, Line 46: The flag is parsed This comment need an update. It does not parse FLAG anymore. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 63 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 18:35:56 +0000 Gerrit-HasComments: Yes
