Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21990 )
Change subject: BLOG: Add Codegen cache for low latency queries ...................................................................... Patch Set 1: (3 comments) Thank you for adding new blog post content! http://gerrit.cloudera.org:8080/#/c/21990/1/blog/authors/michael-smith-yida-wu-david-rorke-abhishek-rawat/index.html File blog/authors/michael-smith-yida-wu-david-rorke-abhishek-rawat/index.html: http://gerrit.cloudera.org:8080/#/c/21990/1/blog/authors/michael-smith-yida-wu-david-rorke-abhishek-rawat/index.html@1 PS1, Line 1: <!DOCTYPE html> nit: can we tell Nikola to generate individual author page, but not this combo authors page? http://gerrit.cloudera.org:8080/#/c/21990/1/nikola_site_generator/images/codegen-cache-perf.png File nikola_site_generator/images/codegen-cache-perf.png: PS1: nit: It is possible to just symlink the image dir to avoid duplicates? ln -s blog/images nikola_site_generator/images http://gerrit.cloudera.org:8080/#/c/21990/1/nikola_site_generator/themes/impala-theme/templates/index.tmpl File nikola_site_generator/themes/impala-theme/templates/index.tmpl: http://gerrit.cloudera.org:8080/#/c/21990/1/nikola_site_generator/themes/impala-theme/templates/index.tmpl@48 PS1, Line 48: Judging by the generated html, I think authors line all goes into this branch. Can we remove this spaces and line it up to match L51 indent please? The same for post_header.tmpl -- To view, visit http://gerrit.cloudera.org:8080/21990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I38cebcccdd61b5f10bdb1dd6fecf5584646290e4 Gerrit-Change-Number: 21990 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 22:11:53 +0000 Gerrit-HasComments: Yes
