Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...................................................................... Patch Set 14: Code-Review+1 (1 comment) This might be a good opportunity to run clang-format-diff against HEAD^ and take any small style fixes. http://gerrit.cloudera.org:8080/#/c/20494/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20494/14//COMMIT_MSG@12 PS14, Line 12: Updates based on how values are used: > "Safe to always follow new code": each individual change is pretty small an Ack -- To view, visit http://gerrit.cloudera.org:8080/20494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Gerrit-Change-Number: 20494 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2024 17:37:04 +0000 Gerrit-HasComments: Yes
