Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 67: (5 comments) http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4661 PS67, Line 4661: recursively walking Can this turned into simple loop instead of recursive call? http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4699 PS67, Line 4699: .getCanonicalPath() : .subList(0, 3) I think it is clearer to create new method in Path class with intention of not collecting beyond column name here. If this is a view column, you might be able to trace it back to find the actual referred column? https://gerrit.cloudera.org/c/21955/15/fe/src/main/java/org/apache/impala/planner/AggregationNode.java#343 http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Path.java File fe/src/main/java/org/apache/impala/analysis/Path.java: http://gerrit.cloudera.org:8080/#/c/21142/67/fe/src/main/java/org/apache/impala/analysis/Path.java@513 PS67, Line 513: // Unnest expressions of columns from views have a root description with a > Yes. That test was failing because the call to rootDesc_.getPath().getCano There are many nullable fields around SlotRef, SlotDesc, Path, TupleDesc, etc. I'm contemplating whether it is beneficial to put @Nullable annotation around them. http://gerrit.cloudera.org:8080/#/c/21142/64/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21142/64/tests/common/impala_test_suite.py@1419 PS64, Line 1419: wait_for_log_exists > I think all tests that does log line validation should consider setting --l Or disable it entirely, --logbuflevel=-1 Anyway, marking this as resolved. I'm looking if we can add new param in with_args fixture to warn checking logs without disabling log buffering. http://gerrit.cloudera.org:8080/#/c/21142/64/tests/common/impala_test_suite.py@1437 PS64, Line 1437: "come into existence after {}x{} seconds".format(actual_log_path, max_ > Not seeing changes in ps66. Did you miss it? Done -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 67 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2024 22:20:33 +0000 Gerrit-HasComments: Yes
