Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22006 )
Change subject: CustomClusterTestSuite for whole class ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22006/1/tests/custom_cluster/test_tuple_cache_tpc_queries.py File tests/custom_cluster/test_tuple_cache_tpc_queries.py: http://gerrit.cloudera.org:8080/#/c/22006/1/tests/custom_cluster/test_tuple_cache_tpc_queries.py@35 PS1, Line 35: super(TestTupleCacheTpcBase, cls).add_test_dimensions() Should probably override add_custom_cluster_constraints to use parquet. Or we could use create_single_exec_option_dimension, add our own parquet constraint, and ignore the custom cluster methods. -- To view, visit http://gerrit.cloudera.org:8080/22006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a08694edcf8cc340d89a0fb33beb8229163b356 Gerrit-Change-Number: 22006 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 31 Oct 2024 00:03:52 +0000 Gerrit-HasComments: Yes
