Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21989 )
Change subject: IMPALA-13495: Make exceptions from the Calcite planner easiser to classify ...................................................................... Patch Set 1: (2 comments) I added a bit of code in the new upload to report UnsupportedFeatureException for tables that have complex types. This currently produces a ClassCastException, which seems weird. http://gerrit.cloudera.org:8080/#/c/21989/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21989/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-13495: Make exceptions from the Calcite planner easiser to classify > typo: easier Done http://gerrit.cloudera.org:8080/#/c/21989/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteQueryParser.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteQueryParser.java: http://gerrit.cloudera.org:8080/#/c/21989/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteQueryParser.java@46 PS1, Line 46: public SqlNode parse() throws AnalysisException { > Why does this throw AnalysisException rather than ParseException? Does this We don't actually need AnalysisException. I was trying to make this like the Parser::parse() function that the regular planner uses, but now that I think about it, this should only use ParseException for now. -- To view, visit http://gerrit.cloudera.org:8080/21989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6702ceac1d1d67c3d82ec357d938f12a6cf1c828 Gerrit-Change-Number: 21989 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2024 23:09:00 +0000 Gerrit-HasComments: Yes
