Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22008 )
Change subject: IMPALA-13471: test_enable_reading_puffin() seems to fail in the Ozone build ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22008/2/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/22008/2/testdata/datasets/functional/functional_schema_template.sql@3234 PS2, Line 3234: ---- DATASET : functional : ---- BASE_TABLE_NAME : iceberg_with_puffin_stats : ---- CREATE : CREATE EXTERNAL TABLE IF NOT EXISTS {db_name}{db_suffix}.{table_name} : STORED AS ICEBERG : LOCATION '/test-warehouse/iceberg_test/iceberg_with_puffin_stats' : TBLPROPERTIES('write.format.default'='parquet', 'iceberg.catalog'='hadoop.tables'); : ---- DEPENDENT_LOAD : `hadoop fs -mkdir -p /test-warehouse/iceberg_test && \ : hadoop fs -put -f ${IMPALA_HOME}/testdata/data/iceberg_test/iceberg_with_puffin_stats /test-warehouse/iceberg_test/ : ==== Do we still need this? http://gerrit.cloudera.org:8080/#/c/22008/2/testdata/datasets/functional/schema_constraints.csv File testdata/datasets/functional/schema_constraints.csv: http://gerrit.cloudera.org:8080/#/c/22008/2/testdata/datasets/functional/schema_constraints.csv@73 PS2, Line 73: table_name:iceberg_with_puffin_stats, constraint:restrict_to, table_format:parquet/none/none Do we still need this? http://gerrit.cloudera.org:8080/#/c/22008/2/tests/util/iceberg_metadata_util.py File tests/util/iceberg_metadata_util.py: http://gerrit.cloudera.org:8080/#/c/22008/2/tests/util/iceberg_metadata_util.py@144 PS2, Line 144: def add_prefix_to_statistics(table_params, statistics): : statistics['statistics-path'] = generate_new_path( : table_params, statistics['statistics-path']) : return statistics With this fix the pre-loaded table would also work well, right? Though I think it's better to create tables on the fly and not pollute the functional_parquet database unnecessarily. -- To view, visit http://gerrit.cloudera.org:8080/22008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7afec1c70d7b43bae98289d65749b01ca720e7f7 Gerrit-Change-Number: 22008 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 17:54:30 +0000 Gerrit-HasComments: Yes
