Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21961 )
Change subject: IMPALA-13468: Fix various aggregation issues in aggregation.test ...................................................................... IMPALA-13468: Fix various aggregation issues in aggregation.test Various small issues fixed including: - There is a special operator dedicated to scalar functions not handled in Calcite. The special agg operator equivalent was created (ImpalaAggOperator) - Grouping_id function needs to be handled in a special way, calling AggregateFunction.createRewrittenFunction - A custom Avg operator was created to handle avg(TIMESTAMP) which isn't allowed in Calcite. - A custom Min/Max operator was created to handle min(NULL) and min(char types). - The corr, covar_pop, and covar_samp functions use the default Impala function resolver rather than the Calcite resolver. Change-Id: I038127d6a2f228ae8d263e983b1906e99ae05f77 Reviewed-on: http://gerrit.cloudera.org:8080/21961 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAggOperator.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAvgAggFunction.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaGroupingIdFunction.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaMinMaxAggFunction.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperator.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperatorTable.java 9 files changed, 414 insertions(+), 99 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I038127d6a2f228ae8d263e983b1906e99ae05f77 Gerrit-Change-Number: 21961 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
