Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 14: (6 comments) http://gerrit.cloudera.org:8080/#/c/21616/13/be/src/rpc/authentication-test.cc File be/src/rpc/authentication-test.cc: http://gerrit.cloudera.org:8080/#/c/21616/13/be/src/rpc/authentication-test.cc@304 PS13, Line 304: : // Unit test for GetEffectiveShortUser(). > I reworked the user name handling to do some validation of kerberos names. Done http://gerrit.cloudera.org:8080/#/c/21616/13/be/src/rpc/authentication-test.cc@323 PS13, Line 323: {"krbtgt/east.example....@west.example.com", "krbtgt"}, : {"User1/admin/STAFF/employ...@west.example.com", "User1"} : }; : for (const auto& pair : kerberos_name_mappings) { > The kerberos user name is potentially very complex but I used the regex fro Done http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/rpc/authentication-test.cc File be/src/rpc/authentication-test.cc: http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/rpc/authentication-test.cc@324 PS14, Line 324: "User1/admin/STAFF/employ...@west.example.com" What is the expected short name for following case? /User1/admin/STAFF/employ...@west.example.com employees@ http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/scheduling/admission-controller.cc@2527 PS14, Line 2527: DCHECK(status.ok()) Use DCHECK_OK(status); http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/scheduling/admission-controller.cc@2527 PS14, Line 2527: Should never happen as nit: "Should never fail because" http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/util/auth-util.h File be/src/util/auth-util.h: http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/util/auth-util.h@46 PS14, Line 46: to a short username. nit: "to a short username (i.e., the testuser in testuser/s...@example.com)." -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 14 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Nov 2024 22:14:11 +0000 Gerrit-HasComments: Yes
