Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21976 )
Change subject: IMPALA-13481: Add support for various agg and analytic functions ...................................................................... Patch Set 5: (22 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java: http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@59 PS5, Line 59: protected static final Logger LOG = LoggerFactory.getLogger(RewriteRexOverRule.class.getName()); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@135 PS5, Line 135: RelDataType bigintType = rexBuilder.getTypeFactory().createSqlType(SqlTypeName.BIGINT); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@140 PS5, Line 140: RexNode countNode = rexBuilder.makeOver(bigintType, ImpalaCustomOperatorTable.COUNT, over.getOperands(), line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@145 PS5, Line 145: rexBuilder.makeCast(bigintType, rexBuilder.makeExactLiteral(BigDecimal.valueOf(1))); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@152 PS5, Line 152: return rexBuilder.makeCall(ImpalaCustomOperatorTable.DIVIDE, numeratorDouble, denominatorDouble); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@167 PS5, Line 167: RelDataType bigintType = rexBuilder.getTypeFactory().createSqlType(SqlTypeName.BIGINT); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@173 PS5, Line 173: rexBuilder.makeCast(bigintType, rexBuilder.makeExactLiteral(BigDecimal.valueOf(1))); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@174 PS5, Line 174: RexNode rankNodeMinusOne = rexBuilder.makeCall(ImpalaCustomOperatorTable.MINUS, rankNode, one); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@177 PS5, Line 177: over.getOperands(), over.getWindow().partitionKeys, ImmutableList.of() /*orderKeys */, line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@180 PS5, Line 180: RexNode countNodeMinusOne = rexBuilder.makeCall(ImpalaCustomOperatorTable.MINUS, countNode, one); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@182 PS5, Line 182: RexNode rankDivCount = rexBuilder.makeCall(ImpalaCustomOperatorTable.DIVIDE, rankDouble, countDouble); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@183 PS5, Line 183: RexNode caseCountOne = rexBuilder.makeCall(SqlStdOperatorTable.EQUALS, countNode, one); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@184 PS5, Line 184: RexNode zeroDouble = rexBuilder.makeCast(over.type, rexBuilder.makeExactLiteral(BigDecimal.valueOf(0))); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@185 PS5, Line 185: return rexBuilder.makeCall(SqlStdOperatorTable.CASE, caseCountOne, zeroDouble, rankDivCount); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@198 PS5, Line 198: RelDataType bigintType = rexBuilder.getTypeFactory().createSqlType(SqlTypeName.BIGINT); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@199 PS5, Line 199: RexNode rowNumberNode = rexBuilder.makeOver(bigintType, SqlStdOperatorTable.ROW_NUMBER, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@209 PS5, Line 209: rexBuilder.makeCast(bigintType, rexBuilder.makeExactLiteral(BigDecimal.valueOf(1))); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@211 PS5, Line 211: rexBuilder.makeCast(bigintType, rexBuilder.makeExactLiteral(BigDecimal.valueOf(0))); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@213 PS5, Line 213: rexBuilder.makeCall(new ImpalaAggOperator("least"), countNode, over.getOperands().get(0)); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@217 PS5, Line 217: rexBuilder.makeCall(ImpalaCustomOperatorTable.MULTIPLY, minCountNTile, rowNumberMinusOne); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@218 PS5, Line 218: RexNode NTileMinusOne = rexBuilder.makeCall(new ImpalaOperator("int_divide"), numeratorInt, countNode); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/21976/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@219 PS5, Line 219: return rexBuilder.makeCall(over.getType(), ImpalaCustomOperatorTable.PLUS, ImmutableList.of(NTileMinusOne, one)); line too long (119 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c69a60c63872b2964688f395b662a85698555e Gerrit-Change-Number: 21976 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Sat, 02 Nov 2024 20:26:39 +0000 Gerrit-HasComments: Yes
