Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22015 )
Change subject: IMPALA-13507: Allow disabling glog buffering via with_args fixture ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/22015/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22015/5//COMMIT_MSG@36 PS5, Line 36: > Please explain the reason behind this modification. Done http://gerrit.cloudera.org:8080/#/c/22015/5/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/5/tests/common/custom_cluster_test_suite.py@175 PS5, Line 175: if reset_ranger: > This change (and also for impalad_graceful_shutdown) is a backwards-compati I search git log and found no history of None assignment. git log -S "reset_ranger=None" git log -S "impalad_graceful_shutdown=None" So I think this change is safe. http://gerrit.cloudera.org:8080/#/c/22015/5/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/5/tests/common/impala_test_suite.py@1370 PS5, Line 1370: LOG.warning( > Please add details on setting `disable_log_buffering=True` in custom cluste Done -- To view, visit http://gerrit.cloudera.org:8080/22015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56fb1746b8f3cea9f3db3514a86a526dffb44a61 Gerrit-Change-Number: 22015 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2024 19:43:30 +0000 Gerrit-HasComments: Yes
