Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21777 )
Change subject: IMPALA-13334: Fix test_sort.py DCHECK hit when max_sort_run_size>0 ...................................................................... Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21777/8/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/21777/8/tests/query_test/test_sort.py@404 PS8, Line 404: # Check that spilling was successful. : assert re.search(r'\s+\- SpilledRuns: [1-9]', query_result.runtime_profile) nit: This is OK if num SpilledRuns does not need to be consistent between test_array_sort and test_array_sort_with_limit. If it is indeed important, then this assertion might be better: if exec_option['max_sort_run_size'] > 0: assert re.search(r'\s+\- SpilledRuns: [1-9]', query_result.runtime_profile) else: assert "SpilledRuns: 3" in query_result.runtime_profile Please double check with Daniel. -- To view, visit http://gerrit.cloudera.org:8080/21777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I943d8edcc87df168448a174d6c9c6b46fe960eae Gerrit-Change-Number: 21777 Gerrit-PatchSet: 8 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2024 21:50:39 +0000 Gerrit-HasComments: Yes
