Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22033 )
Change subject: IMPALA-13505: Fix NPE in Calcite Planner ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22033/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/22033/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4698 PS1, Line 4698: return; // Note, since this statement is within a lambda function, this return I'd like to warn on these; I think they're issues in the Calcite parser we'll want to fix eventually. Or do we know what's getting flagged, and are sure it shouldn't be a named column? http://gerrit.cloudera.org:8080/#/c/22033/1/tests/custom_cluster/test_workload_mgmt_sql_details.py File tests/custom_cluster/test_workload_mgmt_sql_details.py: http://gerrit.cloudera.org:8080/#/c/22033/1/tests/custom_cluster/test_workload_mgmt_sql_details.py@461 PS1, Line 461: res = client.execute("SELECT s_store_name, sum(ss_net_profit) FROM store_sales," Can we refine this query at all and still hit the issue? Would help with determining what needs to change in the parser later. http://gerrit.cloudera.org:8080/#/c/22033/1/tests/custom_cluster/test_workload_mgmt_sql_details.py@521 PS1, Line 521: assert res.success Should we verify that some columns were identified? -- To view, visit http://gerrit.cloudera.org:8080/22033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d282120e596fd39a569d1ce9b25024f4f174dd0 Gerrit-Change-Number: 22033 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2024 21:26:57 +0000 Gerrit-HasComments: Yes
