Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22014 )

Change subject: IMPALA-13154: Update stats when loading an HDFS table
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22014/4/tests/custom_cluster/test_web_pages.py
File tests/custom_cluster/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/22014/4/tests/custom_cluster/test_web_pages.py@540
PS4, Line 540:     assert table_in_list(response_json, "high_file_count_tables")
> Can we verify the values as well? E.g. the table has 24 files. The estimate
Please ignore checking the precise value of estimated memory. It's calculated 
base on numPartitions, numFiles, numBlocks and whether there are incremental 
stats. On cloud storages, there are no blocks so the value will be different. 
We can just check the estimated memory size is a valid value (e.g. >0).



--
To view, visit http://gerrit.cloudera.org:8080/22014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940
Gerrit-Change-Number: 22014
Gerrit-PatchSet: 4
Gerrit-Owner: Xuebin Su <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Wed, 06 Nov 2024 03:02:39 +0000
Gerrit-HasComments: Yes

Reply via email to