Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 )
Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/8523/12/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/8523/12/common/thrift/Frontend.thrift@375 PS12, Line 375: per_node_scan_ranges Thanks, the new thrift structures make more sense to me. Maybe it's simpler by moving the "union" up one level. i.e. make this: map<Types.TPlanNodeId, Struct<ConcreteList, GeneratorSpecList>> Then the backend can be simplified: the "ConcreteList" is already in the format you need, and the GeneratorSpecList can be converted to a ConcreteList in one go that you pass to the scheduler. So then no need for the iterator thingy. What do you think? http://gerrit.cloudera.org:8080/#/c/8523/12/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/8523/12/common/thrift/PlanNodes.thrift@202 PS12, Line 202: THdfsFileSplitGeneratorSpec update -- To view, visit http://gerrit.cloudera.org:8080/8523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I326065adbb2f7e632814113aae85cb51ca4779a5 Gerrit-Change-Number: 8523 Gerrit-PatchSet: 12 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 17 May 2018 21:48:32 +0000 Gerrit-HasComments: Yes