Hello Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22030
to look at the new patch set (#4).
Change subject: IMPALA-13512: Print .test file name if PlannerTest fail
......................................................................
IMPALA-13512: Print .test file name if PlannerTest fail
This patch improve PlannerTest by printing the path to .test file that
is failed. It also skip printing VERBOSE plan if
PlannerTestOption.EXTENDED_EXPLAIN is specified, since EXTENDED level
already contains sufficient details including tuples, sizes, and
cardinality.
This patch also change target path to save the updated end-to-end test file
if --update_results parameter is set. For example:
Before:
$EE_TEST_LOGS_DIR/tpcds-decimal_v2-q98.test
After:
$EE_TEST_LOGS_DIR/impala_updated_results/tpcds/queries/tpcds-decimal_v2-q98.test
Also ensure that the updated test file ends with a newline.
Testing:
- Manualy run modified PlannerTest that will fail and set
EXTENDED_EXPLAIN test option. Verified that .test file name is
printed and VERBOSE plan is not printed.
- Manually run TestTpcdsDecimalV2Query with --update_results parameter
and confirm the updated test file path is correct.
Change-Id: I5e15af93d9016d78ac0575c433146c8513a11949
---
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
M fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
M tests/common/impala_test_suite.py
M tests/util/test_file_parser.py
4 files changed, 31 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/22030/4
--
To view, visit http://gerrit.cloudera.org:8080/22030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e15af93d9016d78ac0575c433146c8513a11949
Gerrit-Change-Number: 22030
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
