Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22041 )
Change subject: IMPALA-13528: Calcite planner; handle unsupported query options ...................................................................... Patch Set 1: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22041/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22041/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@195 PS1, Line 195: if (queryCtx.getTQueryCtx().getClient_request().getQuery_options().isAppx_count_distinct()) { line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1cc23a7447c052e81a42141ec052b6af4ad5e4a Gerrit-Change-Number: 22041 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 21:39:47 +0000 Gerrit-HasComments: Yes
