Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 5: (4 comments) This seems useful. http://gerrit.cloudera.org:8080/#/c/21970/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21970/5//COMMIT_MSG@35 PS5, Line 35: "www/scripts" directory. Everything in the www/ directory gets packaged as part of an Impala distribution. i'd rather put these somewhere else, maybe a subdirectory of infra/. http://gerrit.cloudera.org:8080/#/c/21970/1/www/scripts/eslint.config.js File www/scripts/eslint.config.js: http://gerrit.cloudera.org:8080/#/c/21970/1/www/scripts/eslint.config.js@1 PS1, Line 1: // Licensed to the Apache Software Foundation (ASF) under one > This should have a license if we can add it. Done http://gerrit.cloudera.org:8080/#/c/21970/5/www/scripts/eslint.config.js File www/scripts/eslint.config.js: http://gerrit.cloudera.org:8080/#/c/21970/5/www/scripts/eslint.config.js@27 PS5, Line 27: "no-unused-vars": "warn", > Missing space after key 'no-unused-vars'. Needs to be addressed. http://gerrit.cloudera.org:8080/#/c/21970/1/www/scripts/eslint/eslint_custom_output_formatter.js File www/scripts/eslint/eslint_custom_output_formatter.js: http://gerrit.cloudera.org:8080/#/c/21970/1/www/scripts/eslint/eslint_custom_output_formatter.js@1 PS1, Line 1: // Licensed to the Apache Software Foundation (ASF) under one > RAT expects a license comment. Done -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 22:35:48 +0000 Gerrit-HasComments: Yes
