Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21665 )
Change subject: IMPALA-12865: enable_reload_events breaks enable_skipping_older_events by pushing lastRefreshEventId too high ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/21665/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21665/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7176 PS3, Line 7176: l.getFullName()); > Instead of setting 'lastRefreshEventId_' back to -1 in this case, I think w Good catch! Implemented it in the latest patch set. http://gerrit.cloudera.org:8080/#/c/21665/6/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21665/6/tests/custom_cluster/test_events_custom_configs.py@1201 PS6, Line 1201: 5000 > Can we set this to 4000? In my local env, 2000 is not enough to fail the te I ran 5 times in my local and it failed all the time with out the fix. These timing issues can turn out flaky in future if we don't set a bigger delay. I agree with you. http://gerrit.cloudera.org:8080/#/c/21665/6/tests/custom_cluster/test_events_custom_configs.py@1212 PS6, Line 1212: handle = self.client.execute_async("refresh {} partition(year=2024)".format(tbl)) > Can we get the handle and make sure the statement actually finishes? E.g. Ack -- To view, visit http://gerrit.cloudera.org:8080/21665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90039da77ec561c5aede44456f88c6650582815b Gerrit-Change-Number: 21665 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2024 19:36:35 +0000 Gerrit-HasComments: Yes
