Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21994 )
Change subject: IMPALA-13064: Install service for linux packaging. ...................................................................... Patch Set 2: (3 comments) Thanks for working on this! I just have some minor comments. http://gerrit.cloudera.org:8080/#/c/21994/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21994/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-13064: Install service for linux packaging. nit: remove one space before "Install" and remove period at the end http://gerrit.cloudera.org:8080/#/c/21994/2/package/CMakeLists.txt File package/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/21994/2/package/CMakeLists.txt@89 PS2, Line 89: WORLD_EXECUTE) IIUC, this means the permission is 777 which is too weak. Can we remove GROUP_WRITE and WORLD_WRITE? http://gerrit.cloudera.org:8080/#/c/21994/2/package/etc/init.d/catalogd File package/etc/init.d/catalogd: http://gerrit.cloudera.org:8080/#/c/21994/2/package/etc/init.d/catalogd@35 PS2, Line 35: /bin/sh Is there a reason to use "sh"? I think we use "bash" in impala.sh https://github.com/apache/impala/blob/fe3f82179fa0726af0645d01f90a2bf966175b75/package/bin/impala.sh#L1 -- To view, visit http://gerrit.cloudera.org:8080/21994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If202e91e4b05adbc96cd5c556654901d2f7ca9fe Gerrit-Change-Number: 21994 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 11 Nov 2024 01:18:45 +0000 Gerrit-HasComments: Yes
