Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21932 )
Change subject: IMPALA-13509: Copy rows directly to OutboundRowBatch during hash partitioning ...................................................................... Patch Set 13: Code-Review+2 (3 comments) Left a few more nits, otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/21932/13/be/src/runtime/krpc-data-stream-sender-ir.cc File be/src/runtime/krpc-data-stream-sender-ir.cc: http://gerrit.cloudera.org:8080/#/c/21932/13/be/src/runtime/krpc-data-stream-sender-ir.cc@63 PS13, Line 63: nit: indentation is off by 1 http://gerrit.cloudera.org:8080/#/c/21932/13/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21932/13/be/src/runtime/krpc-data-stream-sender.cc@a762 PS13, Line 762: : It became a bit obsolete as Channel now has no Addrow() function. http://gerrit.cloudera.org:8080/#/c/21932/13/be/src/runtime/tuple-ir.cc File be/src/runtime/tuple-ir.cc: http://gerrit.cloudera.org:8080/#/c/21932/13/be/src/runtime/tuple-ir.cc@67 PS13, Line 67: if (!dst_tuple->TryDeepCopyStrings(&dst, dst_end, &offset, desc, convert_ptrs)) { : return false; : } : if (!dst_tuple->TryDeepCopyCollections(&dst, dst_end, &offset, desc, convert_ptrs)) { : return false; : } nit: in some cases we use RETURN_IF_FALSE macros for this (that also adds UNLIKELY to the condition). -- To view, visit http://gerrit.cloudera.org:8080/21932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81a16c2f0fcfc1f3adef7077b3932a29a0f15a8f Gerrit-Change-Number: 21932 Gerrit-PatchSet: 13 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 11 Nov 2024 17:49:41 +0000 Gerrit-HasComments: Yes
