Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22060 )
Change subject: IMPALA-5792: Eliminate duplicate beeswax python code ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22060/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/22060/1/shell/impala_client.py@210 PS1, Line 210: latency = prettyprint_time(latency) : cardinalit > Before this change, these two strings were concatenated - as far as I can s Good idea! Done. http://gerrit.cloudera.org:8080/#/c/22060/1/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/22060/1/tests/beeswax/impala_beeswax.py@255 PS1, Line 255: separate_prefix_column=True) > Optional: Instead of this, you could define a list with the keys: Done http://gerrit.cloudera.org:8080/#/c/22060/1/tests/beeswax/impala_beeswax.py@256 PS1, Line 256: er > We could use "len(row)" instead of a constant. Changed to assert len(keys) == len(row) -- To view, visit http://gerrit.cloudera.org:8080/22060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica57c90dd571d9ac74d76d9830da26c7fe20c74f Gerrit-Change-Number: 22060 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2024 15:25:33 +0000 Gerrit-HasComments: Yes
