Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22047 )
Change subject: IMPALA-2945: Account for duplicate keys on multiple nodes preAgg ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22047/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22047/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@334 PS1, Line 334: // Take conjuncts into account. : long cardBeforeConjunct = cardinality_; : long cardAfterConjun > This is leftover from old code and can be reverted. Done -- To view, visit http://gerrit.cloudera.org:8080/22047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04c563e59421928875b340cb91654b9d4bc80b55 Gerrit-Change-Number: 22047 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2024 21:58:03 +0000 Gerrit-HasComments: Yes
