Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21665 )
Change subject: IMPALA-12865: Fix wrong lastRefreshEventId set by firing RELOAD events ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/21665/10/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/21665/10/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1384 PS10, Line 1384: LOG.info("last refreshed event id for the partition: {} of table: {} set to: {}", : getPartitionName(), table_.getFullName(), lastRefreshEventId_); This could be too verbose if we refresh a table with many (e.g. 1M or 100K) partitions. We saw a similar issue in IMPALA-10076 where the whole log file is full of partition logs. It'd be better to let the caller do the logging, e.g. https://github.com/apache/impala/blob/c54d8ad4692768ff270947bc9a2f0f6fe629c701/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java#L2003-L2004 So if the caller just refresh a single partition, it can add a log like this. If the caller refresh all partitions, it just log for the table. -- To view, visit http://gerrit.cloudera.org:8080/21665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90039da77ec561c5aede44456f88c6650582815b Gerrit-Change-Number: 21665 Gerrit-PatchSet: 10 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 01:02:47 +0000 Gerrit-HasComments: Yes
