Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21616 )

Change subject: IMPALA-12345: Add user quotas to Admission Control
......................................................................


Patch Set 19: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21616/18//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21616/18//COMMIT_MSG@75
PS18, Line 75:
> Done
Ack


http://gerrit.cloudera.org:8080/#/c/21616/18/be/src/scheduling/admission-controller.h
File be/src/scheduling/admission-controller.h:

http://gerrit.cloudera.org:8080/#/c/21616/18/be/src/scheduling/admission-controller.h@482
PS18, Line 482:     const std::string& user;
> Thanks
Ack


http://gerrit.cloudera.org:8080/#/c/21616/18/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

http://gerrit.cloudera.org:8080/#/c/21616/18/be/src/scheduling/admission-controller.cc@80
PS18, Line 80: DEFINE_string_hidden(injected_group_members_debug_only, "",
> Thanks
Ack



--
To view, visit http://gerrit.cloudera.org:8080/21616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41
Gerrit-Change-Number: 21616
Gerrit-PatchSet: 19
Gerrit-Owner: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Nov 2024 00:33:52 +0000
Gerrit-HasComments: Yes

Reply via email to