k.venureddy2...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/21971 )
Change subject: IMPALA-13403: Refactor the checks of skip reloading file metadata for ALTER_TABLE events ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21971/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21971/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1937 PS4, Line 1937: if (!Objects.equals(beforeTable.getSd(), afterTable.getSd())) { : if (isTrivialSdPropsChanged(beforeTable.getSd(), afterTable.getSd())) { : skipFileMetadata = true; : } else { : return false; : } : } : if (isFieldSchemaChanged(beforeTable, afterTable) || : isTableOwnerChanged(beforeTable.getOwner(), afterTable.getOwner())) { : skipFileMetadata = true; : } : if (!isCustomTblPropsChanged(whitelistedTblProperties, beforeTable, afterTable)) { : skipFileMetadata = true; : } else { : return false; : } : infoLog("Skipping reloading of file metadata for table {}.{} since SD and " + : "whitelistedTblProperties has not changed.", dbName_, tblName_); : return skipFileMetadata; Field schema change seem to be already considered as trivial change with isTrivialSdPropsChanged() since we do sd.unsetCols() in normalizeStorageDescriptor() before comparing storage descriptors. I think, we do not need explicit isFieldSchemaChanged(beforeTable, afterTable) again. What is your opinion ? How about we reorder something like this - // If SD has not trivial changes return false i.e., cannot skip file meta reload if (!Objects.equals(beforeTable.getSd(), afterTable.getSd()) && !isTrivialSdPropsChanged(beforeTable.getSd(), afterTable.getSd())) { return false; } // If custom table properties are changed, return false if (isCustomTblPropsChanged(whitelistedTblProperties, beforeTable, afterTable)) { return false; } // Check for table object fields such as owner etc ... -- To view, visit http://gerrit.cloudera.org:8080/21971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia969dd32385ac5a1a9a65890a5ccc8cd257f4b97 Gerrit-Change-Number: 21971 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Nov 2024 09:43:11 +0000 Gerrit-HasComments: Yes
