Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22029 )
Change subject: IMPALA-13511: Calcite planner: support sub-second datetime parts ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22029/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaSqlIntervalQualifier.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaSqlIntervalQualifier.java: http://gerrit.cloudera.org:8080/#/c/22029/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaSqlIntervalQualifier.java@71 PS2, Line 71: if (!timeUnitRange.equals(TimeUnitRange.MILLISECOND) && > nit: could this be a switch statement? I generally assume those are easier Done http://gerrit.cloudera.org:8080/#/c/22029/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaSqlIntervalQualifier.java@106 PS2, Line 106: // validate as YEAR(startPrecision), e.g. 'YY' > Nit: Update comment Done http://gerrit.cloudera.org:8080/#/c/22029/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaSqlIntervalQualifier.java@148 PS2, Line 148: private static int[] fillIntervalValueArray( : int sign, : BigDecimal year, : BigDecimal month) { : int[] ret = new int[3]; : : ret[0] = sign; : ret[1] = year.intValue(); : ret[2] = month.intValue(); > (Optional) Nit: This is from the original Calcite code, but we could update Done -- To view, visit http://gerrit.cloudera.org:8080/22029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I392c3900c70e7754a35ef25fc720ba4a2f2e5dd6 Gerrit-Change-Number: 22029 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2024 15:45:01 +0000 Gerrit-HasComments: Yes
