Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21869 )
Change subject: IMPALA-11265: Part2: Store Iceberg file descriptors in encoded format ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21869/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21869/2//COMMIT_MSG@16 PS2, Line 16: addiitonal > typo Done http://gerrit.cloudera.org:8080/#/c/21869/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/21869/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@71 PS2, Line 71: private static FileDescriptor decode(EncodedFileDescriptor encodedFd) { > Maybe write a Java unit test that runs decode(encode(fd)) and checks the re Done http://gerrit.cloudera.org:8080/#/c/21869/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@83 PS2, Line 83: public boolean equals(Object obj) { > Wouldn't it make sense to include the equals() and hashCode() overrides in I also thought of that. I went for this approach because these functions would only be useful for FileDescriptors coming from the IcebergContentFileStore, so I figured the less noise I add to HdfsPartition.FileDescriptor the less regression I cause :) http://gerrit.cloudera.org:8080/#/c/21869/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@205 PS2, Line 205: pathHashAndFd > This could be a local variable in the loops below, I think it's good to lim well, this is a copy-pasted code from FeIcebergTable. Done http://gerrit.cloudera.org:8080/#/c/21869/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@337 PS2, Line 337: if (contentFile.content() == FileContent.EQUALITY_DELETES) { : Preconditions.checkState( : icebergMetadata.icebergMetadata().equalityFieldIdsLength() > 0); : } > Probably it's better to throw such exceptions from IcebergScanPlanner. If w Good point. I moved this to IcebergScanPlanner. -- To view, visit http://gerrit.cloudera.org:8080/21869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d7794df999bdaf118158eace26cea610f911c0a Gerrit-Change-Number: 21869 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 18 Nov 2024 10:46:49 +0000 Gerrit-HasComments: Yes
