Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 )
Change subject: IMPALA-5706: Spilling sort optimisations ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/9943/12/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/9943/12/tests/query_test/test_sort.py@135 PS12, Line 135: selected as the pivot (the old method), the sorter tends to get stuck selecting the > I gave this a second look and apparently I mis-measured something the last As discussed offline, I couldn't reduce the runtime of this test. As agreed, I'm dropping it as the majority of the spilling sorts have already been covered by the existing tests. -- To view, visit http://gerrit.cloudera.org:8080/9943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74857c1694802e81f1cfc765d2b4e8bc644387f9 Gerrit-Change-Number: 9943 Gerrit-PatchSet: 13 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 18 May 2018 10:20:26 +0000 Gerrit-HasComments: Yes
