Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22052 )
Change subject: IMPALA-13540: Calcite planner: fix wrong results for set operators ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22052/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22052/2//COMMIT_MSG@16 PS2, Line 16: Calcite was returning 2 results here, performing the intersect before > nit: 'results' seems unclear. Can we say 'rows' ? Done http://gerrit.cloudera.org:8080/#/c/22052/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java: http://gerrit.cloudera.org:8080/#/c/22052/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java@227 PS2, Line 227: // than union and except. Impala has equal precedence for all the set operators. > Here's the original Impala commit: I changed the comment here. Is there anything else that needs to be done before commit? -- To view, visit http://gerrit.cloudera.org:8080/22052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic52661a30cc90534ea1a20868799edf9ceed13b6 Gerrit-Change-Number: 22052 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 23:33:10 +0000 Gerrit-HasComments: Yes
