Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 )
Change subject: IMPALA-6131: Track time of last statistics update in metadata ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/10116/12/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10116/12/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2868 PS12, Line 2868: // catalogd would read it back after alter_table, but as this would not work for > Do you have an example in mind when the table should not be reloaded? I loo I agree that today we will always reload the table metadata from the HMS and set a new msTbl. That behavior is not by design though - I think it's unintentional and probably a bug (see for example IMPALA-6994). Personally, I think this comment is difficult to understand because it's explanation relies on (1) understanding what callers will do after calling this function, and (2) understanding what is done for Kudu tables, so there's some loss of abstraction. Imo, it would be clearer to declare a general policy of setting the lastDdlTime in Impala to not rely on the HMS setting it and to avoid having to fetch it from HMS if possible. -- To view, visit http://gerrit.cloudera.org:8080/10116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59a671ac29d352bd92ce40d5cb6662bb23f146b5 Gerrit-Change-Number: 10116 Gerrit-PatchSet: 12 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 18 May 2018 16:39:13 +0000 Gerrit-HasComments: Yes
