Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22070 )

Change subject: IMPALA-13448: Log cause when failing to flush lineage events, 
audit events or profiles
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22070/6/tests/custom_cluster/test_logging.py
File tests/custom_cluster/test_logging.py:

http://gerrit.cloudera.org:8080/#/c/22070/6/tests/custom_cluster/test_logging.py@80
PS6, Line 80:     def setup_method(self, method):
Some tests failed with these errors:
```cp: cannot access 
'/home/ubuntu/Impala/logs/custom_cluster_tests/impala_test_log_flush_failures_dir_bnJJ4b':
 Permission denied
cp: cannot access 
'/home/ubuntu/Impala/logs/custom_cluster_tests/impala_test_log_flush_failures_dir_8BcvkP':
 Permission denied```
I think this is when the test framework is trying to collect logs for the tests 
it can't copy them because it has no permissions.

We could solve this by overriding also teardown_method(), where we would 
restore the permissions on the log directory.
The setup_method() function could first store the original permissions and 
teardown_method() could restore them.



--
To view, visit http://gerrit.cloudera.org:8080/22070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b281d807e47aad98fc256af4e0c2a9dd417c7ac
Gerrit-Change-Number: 22070
Gerrit-PatchSet: 6
Gerrit-Owner: jiangwei <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 20 Nov 2024 10:45:34 +0000
Gerrit-HasComments: Yes

Reply via email to