Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22085
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY ...................................................................... IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY Calls to both of these RPC endpoints are previously logged at VLOG_RPC (or VLOG(2)). This patch change the log level to VLOG_QUERY (or VLOG(1)). This is helpful because both RPC are usually called after query execution complete, but the query handle is not relesed yet. They are also rarely called by client, so they will not be too noisy. Missing query driver log in GetAllQueryHandles is moved to its caller, where the log message is clarified. ImpalaShell._execute_stmt() also modified to call get_runtime_profile() only if show_profile option is true. Testing: - Using impala-shell, run a TPC-DS query followed by 'profile' and summary command. Verify that logs are printed, both with beeswax and HS2 protocol. - Pass core tests. Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1 --- M be/src/service/impala-beeswax-server.cc M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.cc M shell/impala_shell.py 4 files changed, 16 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/22085/1 -- To view, visit http://gerrit.cloudera.org:8080/22085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1 Gerrit-Change-Number: 22085 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]>
