Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22062 )
Change subject: IMPALA-13487: Add profile counters for memory allocation ...................................................................... Patch Set 8: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22062/8/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/22062/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@151 PS8, Line 151: ADD_SUMMARY_STATS_TIMER(scan_node_->runtime_profile(), "ParquetDataPagePoolAllocDuration"); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/22062/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@155 PS8, Line 155: ADD_SUMMARY_STATS_TIMER(scan_node_->runtime_profile(), "ParquetDataPagePoolFreeDuration"); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710 Gerrit-Change-Number: 22062 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 02:35:51 +0000 Gerrit-HasComments: Yes
