Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22093 )
Change subject: IMPALA-13532: Improved concurrent BufferedTupleStream ...................................................................... Patch Set 1: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22093/1/be/src/runtime/buffered-tuple-stream-test.cc File be/src/runtime/buffered-tuple-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/22093/1/be/src/runtime/buffered-tuple-stream-test.cc@1753 PS1, Line 1753: // Don't mix with PrepareForRead. Currently messes with ref counting on pinned pages because line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22093/1/be/src/runtime/buffered-tuple-stream-test.cc@1808 PS1, Line 1808: "$0 out of $1 pages=", BufferedTupleStream::MAX_PAGE_ITER_DEBUG, stream.pages_.size()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22093/1/be/src/runtime/buffered-tuple-stream.cc File be/src/runtime/buffered-tuple-stream.cc: http://gerrit.cloudera.org:8080/#/c/22093/1/be/src/runtime/buffered-tuple-stream.cc@673 PS1, Line 673: return Status(TErrorCode::INTERNAL_ERROR, Substitute("Internal error: couldn't pin " line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22093/1/be/src/runtime/buffered-tuple-stream.cc@677 PS1, Line 677: if (SkipPageRefCount(*read_iter->read_page_) && read_iter->read_page_->is_pinned()) { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2130844613eb9f77f13d31f2c0d5e65cb063736 Gerrit-Change-Number: 22093 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2024 21:43:06 +0000 Gerrit-HasComments: Yes
