Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22094 )

Change subject: IMPALA-13533: Calcite CTE backend
......................................................................


Patch Set 1:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/22094/1/be/src/runtime/buffered-tuple-stream.cc
File be/src/runtime/buffered-tuple-stream.cc:

http://gerrit.cloudera.org:8080/#/c/22094/1/be/src/runtime/buffered-tuple-stream.cc@1131
PS1, Line 1131:       DCHECK(t != nullptr || tuple_size == 0) << "Tuple " << i 
<< " size=" << tuple_size << " ptr=" << t;
line too long (105 > 90)


http://gerrit.cloudera.org:8080/#/c/22094/1/be/src/runtime/descriptors.cc
File be/src/runtime/descriptors.cc:

http://gerrit.cloudera.org:8080/#/c/22094/1/be/src/runtime/descriptors.cc@424
PS1, Line 424:     DCHECK(tuple_desc_map_.back() != NULL) << "DescriptorTbl 
missing tuple id " << row_tuples[i];
line too long (97 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a
Gerrit-Change-Number: 22094
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 21 Nov 2024 21:45:53 +0000
Gerrit-HasComments: Yes

Reply via email to