Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21959 )
Change subject: IMPALA-13370: Read Puffin stats from metadata.json property if available ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21959/6/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java File fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java: http://gerrit.cloudera.org:8080/#/c/21959/6/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java@182 PS6, Line 182: : return res; : } : : private long getNdvFromMetadata(org.apache.iceberg.BlobMetadata blob) { : Strin > In the first round we only registered NDVs in 'result_' where it was availa I see, this a bit subtle, could you please add a comment for this? I guess later we will want to consider older puffin files as well, and keep the NDV from the latest. Will we still want to log duplicates at that point? -- To view, visit http://gerrit.cloudera.org:8080/21959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e92056ce97c4849742db6309562af3b575f647b Gerrit-Change-Number: 21959 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2024 14:34:43 +0000 Gerrit-HasComments: Yes
