Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 )
Change subject: IMPALA-7011: Simplify PlanRootSink control logic ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10449/4/be/src/exec/plan-root-sink.cc File be/src/exec/plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/10449/4/be/src/exec/plan-root-sink.cc@102 PS4, Line 102: consumer_cv_.NotifyAll(); > We could make these NotifyOne() but I think it's inconsequential yeah seems fine to me the way it was since there's no important difference in this case. -- To view, visit http://gerrit.cloudera.org:8080/10449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc75617a253fd43a6122baa4b4dc7aeb1dbe633f Gerrit-Change-Number: 10449 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 18 May 2018 21:01:01 +0000 Gerrit-HasComments: Yes
