Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22102 )
Change subject: IMPALA-13567: Update RowsRead counter more frequently ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22102/2/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/22102/2/be/src/exec/orc/hdfs-orc-scanner.cc@1008 PS2, Line 1008: COUNTER_ADD(scan_node_->rows_read_counter(), orc_root_batch_->numElements); In environments with a lot of scanner threads, this could lead to increased contention updating the counter. However I would be surprised if it was significant compared to scan costs. -- To view, visit http://gerrit.cloudera.org:8080/22102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17f1c40a0e790750ffbd4e987ca181b82cc14c40 Gerrit-Change-Number: 22102 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 19:53:49 +0000 Gerrit-HasComments: Yes
