Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10404 )
Change subject: Moving default sanitizer options into init.cc from shell scripts. ...................................................................... Moving default sanitizer options into init.cc from shell scripts. When running tests with ASAN, you need to set ASAN_OPTIONS explicitly, to avoid various failures. In particular, backend tests fail complaining about memory leaks and tests that use the parquet-reader binary complain similarly. It turns out that we can shove the default options into our code base directly, avoiding the need for users to set it explicitly. I've done the same thing for TSAN and UBSAN. I've manually checked that these are being read. In the UBSAN case, I checked both with gdb and with inotifywatch on the suppressions file. Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b Reviewed-on: http://gerrit.cloudera.org:8080/10404 Reviewed-by: Jim Apple <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/CMakeLists.txt M be/src/common/init.cc M bin/run-backend-tests.sh M bin/start-catalogd.sh M bin/start-impalad.sh M bin/start-statestored.sh 6 files changed, 28 insertions(+), 16 deletions(-) Approvals: Jim Apple: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b Gerrit-Change-Number: 10404 Gerrit-PatchSet: 7 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
