Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21805 )
Change subject: IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/21805/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21805/6//COMMIT_MSG@23 PS6, Line 23: pushd fe && mvn -fae test -Dtest=JdbcDataSourceTest The individual test case could be ran with mvn, for example (pushd fe && mvn -fae test -Dtest=JdbcDataSourceTest#test02Prepare) But the tests in JdbcDataSourceTest have dependency on previous tests. Please mention that individual test cannot be ran separately for this class. http://gerrit.cloudera.org:8080/#/c/21805/6/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java File fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java: http://gerrit.cloudera.org:8080/#/c/21805/6/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java@95 PS6, Line 95: The unit test cases in this class have dependency. They must be ran sequentially. Please add a comment. http://gerrit.cloudera.org:8080/#/c/21805/6/java/ext-data-source/jdbc/pom.xml File java/ext-data-source/jdbc/pom.xml: http://gerrit.cloudera.org:8080/#/c/21805/6/java/ext-data-source/jdbc/pom.xml@36 PS6, Line 36: <postgres.jdbc.version>${env.IMPALA_POSTGRES_JDBC_DRIVER_VERSION}</postgres.jdb Do we need to make this change and the one below? The test source file is moved to fe directory. Maybe just delete the dependency. -- To view, visit http://gerrit.cloudera.org:8080/21805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127 Gerrit-Change-Number: 21805 Gerrit-PatchSet: 6 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 03 Dec 2024 23:58:08 +0000 Gerrit-HasComments: Yes
