Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22192 )
Change subject: IMPALA-13598: OPTIMIZE redundantly accumulates memory in HDFS WRITER ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Thanks for catching and fixing this! http://gerrit.cloudera.org:8080/#/c/22192/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-optimize.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-optimize.test: http://gerrit.cloudera.org:8080/#/c/22192/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-optimize.test@290 PS1, Line 290: CREATE TABLE ice_tpch_many_parts : PARTITIONED BY SPEC(truncate(1000, l_orderkey)) : STORED BY ICEBERG : AS SELECT * FROM tpch_parquet.lineitem; Currently this table has only 1 file per partition, so issuing OPTMIZE would result in an identical table. In case later we want to set a default FILE_SIZE_THRESHOLD_MB for this command, this test would 'execute' a no-op. We could create a table where each partition contains multiple files by inserting some data in a second round. -- To view, visit http://gerrit.cloudera.org:8080/22192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d451c50c4b6dff9433ab105493051bee106bc63 Gerrit-Change-Number: 22192 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2024 12:17:50 +0000 Gerrit-HasComments: Yes
