Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState ...................................................................... IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState Currently, class PerFilterState is marked with CACHELINE_ALIGNED, which is actually a macro definition of __attribute__((aligned())). For static allocation, it can specify memory alignment, but it cannot specify alignment for dynamic memory allocation. In the code, all PerFilterState objects are dynamically created using make_unique in the function RuntimeFilterBank::BuildFilterMap(), so CACHELINE_ALIGNED does not really have any effect. It might even lead to unexpected situations as described in the JIRA comments. Therefore, this patch replaces CACHELINE_ALIGNED with CacheLineAligned, which supports alignment for dynamic memory allocation. Testing: - Existing tests cover this change. Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff Reviewed-on: http://gerrit.cloudera.org:8080/22147 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/runtime-filter-bank.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff Gerrit-Change-Number: 22147 Gerrit-PatchSet: 4 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]>
