Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22200 )
Change subject: IMPALA-13536: Workload Management Tests Failing on Init Check ...................................................................... Patch Set 4: Code-Review+2 (2 comments) This looks fine to me. Changing my vote to +2. http://gerrit.cloudera.org:8080/#/c/22200/4/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/22200/4/tests/custom_cluster/test_query_live.py@82 PS4, Line 82: disable_log_buffering=True nit: All tests calling wait_for_wm_init_complete will inspect deamon logs. So another improvement idea is to have dedicated log dir by passing these args to CustomClusterTestSuite.with_args fixture: impala_log_dir="{workload_management}", tmp_dir_placeholders=["workload_management"], http://gerrit.cloudera.org:8080/#/c/22200/4/tests/custom_cluster/test_query_live.py@83 PS4, Line 83: test_query_live nit: Please try loop this test for 100 times as preliminary proof that the flakiness is gone. -- To view, visit http://gerrit.cloudera.org:8080/22200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f20a149ab1f45ee3506f098f8594965a24a89d3 Gerrit-Change-Number: 22200 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 18:20:10 +0000 Gerrit-HasComments: Yes
