Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22209
Change subject: IMPALA-13596: Add warnings and exceptions to reading of fair-scheduler file. ...................................................................... IMPALA-13596: Add warnings and exceptions to reading of fair-scheduler file. The fair-scheduler file contains part of the configuration for Admission Control. This change adds some better error handling to the parsing of this file. Where it is safe to do so, new exceptions are thrown; this will cause Impala to refuse to start. This is consistent with other serious configuration errors. Where new exceptions might cause problems with existing configurations, or for less dangerous faults, new warnings are written to the server log. For the recently added User Quota configuration (IMPALA-12345) throw an exception when a duplicate snippet of configuration is found. New warning log messages are added for these cases: - when a user quota at the leaf level is completely ignored because of a user quota at the root level - when there is no user ACL on a leaf level queue. This prevents any queries from being submitted to the queue. Change-Id: Idcd50442ce16e7c4346c6da1624216d694f6f44d --- M fe/src/main/java/org/apache/impala/util/RequestPoolService.java M fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java A fe/src/test/resources/bad_configurations/bad_duplicate_group_limit_leaf.xml A fe/src/test/resources/bad_configurations/bad_duplicate_group_limit_root.xml A fe/src/test/resources/bad_configurations/bad_duplicate_user_limit_leaf.xml A fe/src/test/resources/bad_configurations/bad_duplicate_user_limit_root.xml A fe/src/test/resources/bad_configurations/warnings-fair-scheduler-test.xml M java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java 8 files changed, 264 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/22209/1 -- To view, visit http://gerrit.cloudera.org:8080/22209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idcd50442ce16e7c4346c6da1624216d694f6f44d Gerrit-Change-Number: 22209 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]>
