Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20171 )
Change subject: IMPALA-13551: Produce the shell tarball by pip installing impala-shell ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/20171/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20171/7//COMMIT_MSG@16 PS7, Line 16: impala-shell-4.3.0-SNAPSHOT/impala-shell : /install_py${PYTHON_VERSION} : /install_py${ANOTHER_PYTHON_VERSION} > I think it looks better this way My intention is to describe the directory structure of the shell tarball itself, so that's why I don't include $IMPALA_HOME/shell/build here. Changed this to a similar structure and updated the comment to make it clear that this is about the unpacked shell tarball. http://gerrit.cloudera.org:8080/#/c/20171/7/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20171/7/shell/CMakeLists.txt@70 PS7, Line 70: add_custom_target(shell_impala_build_version : DEPENDS gen-deps "${CMAKE_SOURCE_DIR}/bin/version.info" : COMMAND "${CMAKE_SOURCE_DIR}/shell/gen_impala_build_version.sh" : ) > "make shell_impala_build_version" does not work if I remove shell/gen-py. This is an existing problem. Our Thrift code generation doesn't understand which files are produced for Python or Java (and its understanding of C++ is somewhat incomplete). I filed https://issues.apache.org/jira/browse/IMPALA-13604 for this. One way to recover is to run "make clean" and then "make shell_tarball" (or run buildall.sh without -noclean). -- To view, visit http://gerrit.cloudera.org:8080/20171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb66ab2c5bc7180221f98d9bf5e38d62f4ac036 Gerrit-Change-Number: 20171 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 14 Dec 2024 00:19:39 +0000 Gerrit-HasComments: Yes
