Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21475 )
Change subject: IMPALA-13124: Migrate tests that use 'unittest' package to pytest base class ...................................................................... IMPALA-13124: Migrate tests that use 'unittest' package to pytest base class Some tests were written to use the builtin 'unittest' package. In testing on Python 3, these tests failed with an error like "RuntimeError: generator raised StopIteration". Since Impala tests are standardized on pytests, this converts those locations to use our regular pytest base classes. This required restructing the test_redaction.py custom cluster test to use the pytest setup and teardown methods. It also simplifies the test cases so that each attempted startup gets its own test rather than doing multiple startup attempts in a single test. Testing: - Ran exhaustive job Change-Id: I89e854f64e424a75827929a4f6841066024390e9 Reviewed-on: http://gerrit.cloudera.org:8080/21475 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Riza Suminto <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M tests/custom_cluster/test_redaction.py M tests/shell/test_cookie_util.py M tests/shell/test_kerberos_util.py 3 files changed, 36 insertions(+), 29 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Riza Suminto: Looks good to me, approved Joe McDonnell: Verified -- To view, visit http://gerrit.cloudera.org:8080/21475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I89e854f64e424a75827929a4f6841066024390e9 Gerrit-Change-Number: 21475 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
