Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22245 )
Change subject: IMPALA-13624: Implement textual representation of aggregate event sequences ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22245/1/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/22245/1/be/src/util/runtime-profile.cc@2787 PS1, Line 2787: [](const std::pair<string, AggEventSequence>& pair) { return pair.second; }); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22245/1/be/src/util/runtime-profile.cc@2810 PS1, Line 2810: stream << prefix << " Div. Min Max Avg #Inst. Count\n"; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22245/1/be/src/util/runtime-profile.cc@2852 PS1, Line 2852: stream << PrettyPrinter::Print(ts_list[ts_count].GetInt64(), TUnit::TIME_NS) << "\n"; line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0 Gerrit-Change-Number: 22245 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 19 Dec 2024 14:54:54 +0000 Gerrit-HasComments: Yes
