Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22251 )
Change subject: IMPALA-13630: Avoid holding global lock when closing KrpcDataStreamRecvr ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22251/1/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22251/1/be/src/runtime/krpc-data-stream-mgr.cc@326 PS1, Line 326: closed_stream_expirations_.insert( : make_pair(MonotonicMillis() + STREAM_EXPIRATION_TIME_MS, recvr_id)); > Shouldn't this be done after CancelStream() at L341? It doesn't matter, closed_stream_expirations_ / closed_stream_cache_ only store the id of receiver and doesn't affect it's lifetime. >From the sender's point of view removing the receiver from receiver_map_ and >cancelling it have similar effect, RPCs and scheduled deferred RPC >serializations become NOOP. -- To view, visit http://gerrit.cloudera.org:8080/22251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie110722f144400132de1e23813e260dab1de77e7 Gerrit-Change-Number: 22251 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 20 Dec 2024 16:53:49 +0000 Gerrit-HasComments: Yes
